viusal basic input validation integer - basic.visual

Phlip wrote:
> Steve Gerrard wrote:
>
>> MsgBox "How is " & sInput & " an integer?"
>
> As a user, seeing sophomoric crap like that get through gives me
> a very low opinion of the programmer on the other side.

He didn't. That stuff is some fabrication of your newsreader. The
 characters don't exist in his original.

--
"If you want to post a followup via groups.google.com, don't use
the broken "Reply" link at the bottom of the article. Click on
"show options" at the top of the article, then click on the
"Reply" at the bottom of the article headers." - Keith Thompson
More details at: <http://cfaj.freeshell.org/google/>
Also see <http://www.safalra.com/special/googlegroupsreply/>

"Phlip" <phlip2005@gmail.com> wrote in message
news:Z29Nf.18017$NS6.7159@newssvr30.news.prodigy.com...

> For the OP; handle errors at keystroke time or at turn-around time (when the
> field blurs, or when the current page submits). Then if the error is
> complex, write text into a special field on the form. If the error is
> simple, beep and turn its field red.

OP's question was:
"what is the best way to check the User has entered an integer into an
InputBox?"

Followed with a second post stating:
"unfortunately I am restricted to using inputbox() ... "

>> MsgBox "How is " & sInput & " an integer?"
>
> As a user, seeing sophomoric crap like that get through gives me a very low
> opinion of the programmer on the other side.
>
> Contact with a user should be as sensitive and gentle as possible, to avoid
> looking like the average VB interface.
>

Contact with a NG should be as sensitive and gentle as possible, to avoid
looking like you can't tell the difference between the serious code and the lame
NG humor

"code_wrong" <tac@tac.co.uk> wrote in message
news:4404b324$1_1@mk-nntp-2.news.uk.tiscali.com...
>
> unfortunately I am restricted to using inputbox() ... why? .. if I change
> the method for input now, the students will likely will be traumatised ..
> these are very early days
>

num = VAL(Text1.text)
if num*10 / 10 = INT(num*10/10) then debug.print "whole number" else
debug.print "has decimal"

CBFalconer wrote:
> Phlip wrote:
>> Steve Gerrard wrote:
>>
>>> MsgBox "How is " & sInput & " an integer?"
>> As a user, seeing sophomoric crap like that get through gives me
>> a very low opinion of the programmer on the other side.
>
> He didn't. That stuff is some fabrication of your newsreader. The
> Â characters don't exist in his original.

Nor in Phlips reply...
Phlip was referring to the content of the message itself rather than the
garbage characters your client seems to have added.

--
Dean Earley (dean.earley@icode.co.uk)
i-Catcher Development Team

iCode Systems

"code_wrong" <tac@tac.co.uk> wrote in message
news:4404ac4c$1_3@mk-nntp-2.news.uk.tiscali.com...
> Visual Basic (not dot net)
> what is the best way to check the User has entered an integer into an
> InputBox?
>
> isNumeric() checks for a numeric value .. but does not notify of numbers
> with decimal places
> inputBox returns a string so I could check for decimal point??? this seems
> like overkill
>
> The value returned can be asigned into an Integer type and then a Single
> type ... the two can be compared .. but still this does not complain about
> numbers with decimal places if the fractional part is zero
>
> what is the simple solution?

Interesting discussion , thanks for the replies.
I have decided to provide students with a pre-defined function of my own
design
please review and improve if you can
the function:

Function isInteger(strVal As String) As Boolean

'if not numeric or decimal point found
If Not IsNumeric(strVal) Or InStr(strVal, ".") Then
isInteger = False
Else
isInteger = True
End If

End Function

"code_wrong" <tac@tac.co.uk> wrote in message
news:4404ac4c$1_3@mk-nntp-2.news.uk.tiscali.com...
> Visual Basic (not dot net)
> what is the best way to check the User has entered an integer into an
> InputBox?
>
> isNumeric() checks for a numeric value .. but does not notify of numbers
> with decimal places
> inputBox returns a string so I could check for decimal point??? this seems
> like overkill
>
> The value returned can be asigned into an Integer type and then a Single
> type ... the two can be compared .. but still this does not complain about
> numbers with decimal places if the fractional part is zero
>
> what is the simple solution?

Interesting discussion , thanks for the replies.
I have decided to provide students with a pre-defined function of my own
design
please review and improve if you can
the function:

Function isInteger(strVal As String) As Boolean

'if not numeric or decimal point found
If Not IsNumeric(strVal) Or InStr(strVal, ".") Then
isInteger = False
Else
isInteger = True
End If

End Function

> I have decided to provide students with a pre-defined function of my own
> design
> please review and improve if you can
> the function:
>
> Function isInteger(strVal As String) As Boolean
>
> 'if not numeric or decimal point found
> If Not IsNumeric(strVal) Or InStr(strVal, ".") Then
> isInteger = False
> Else
> isInteger = True
> End If
>
> End Function

From a previous post of mine...

I usually try and steer people away from using IsNumeric to "proof"
supposedly numeric text. Consider this (also see note below):

ReturnValue = IsNumeric("($1,23,,3.4,,,5,,E67$)")

Most people would not expect THAT to return True. IsNumeric has some "flaws"
in what it considers a proper number and what most programmers are looking
for.

I had a short tip published by Pinnacle Publishing in their Visual Basic
Developer magazine that covered some of these flaws. Originally, the tip was
free to view but is now viewable only by subscribers.. Basically, it said
that IsNumeric returned True for things like -- currency symbols being
located in front or in back of the number as shown in my example (also
applies to plus, minus and blanks too); numbers surrounded by parentheses as
shown in my example (some people use these to mark negative numbers);
numbers containing any number of commas before a decimal point as shown in
my example; numbers in scientific notation (a number followed by an upper or
lower case "D" or "E", followed by a number equal to or less than 305 -- the
maximum power of 10 in VB); and Octal/Hexadecimal numbers (&H for
Hexadecimal, &O or just & in front of the number for Octal).

NOTE:
======
In the above example and in the referenced tip, I refer to $ signs and
commas and dots -- these were meant to refer to your currency, thousands
separator and decimal point symbols as defined in your local settings --
substitute your local regional symbols for these if appropriate.

As for your question about checking numbers, here are two functions that I
have posted in the past for similar questions..... one is for digits only
and the other is for "regular" numbers:

Function IsDigitsOnly(Value As String) As Boolean
IsDigitsOnly = Len(Value) > 0 And _
Not Value Like "*[!0-9]*"
End Function

Function IsNumber(ByVal Value As String) As Boolean
' Leave the next statement out if you don't
' want to provide for plus/minus signs
If Value Like "[+-]*" Then Value = Mid$(Value, 2)
IsNumber = Not Value Like "*[!0-9.]*" And _
Not Value Like "*.*.*" And _
Len(Value) > 0 And Value <> "." And _
Value <> vbNullString
End Function

Here are revisions to the above functions that deal with the local settings
for decimal points (and thousand's separators) that are different than used
in the US (this code works in the US too, of course).

Function IsNumber(ByVal Value As String) As Boolean
Dim DP As String
' Get local setting for decimal point
DP = Format$(0, ".")
' Leave the next statement out if you don't
' want to provide for plus/minus signs
If Value Like "[+-]*" Then Value = Mid$(Value, 2)
IsNumber = Not Value Like "*[!0-9" & DP & "]*" And _
Not Value Like "*" & DP & "*" & DP & "*" And _
Len(Value) > 0 And Value <> DP And _
Value <> vbNullString
End Function

I'm not as concerned by the rejection of entries that include one or more
thousand's separators, but we can handle this if we don't insist on the
thousand's separator being located in the correct positions (in other words,
we'll allow the user to include them for their own purposes... we'll just
tolerate their presence).

Function IsNumber(ByVal Value As String) As Boolean
Dim DP As String
Dim TS As String
' Get local setting for decimal point
DP = Format$(0, ".")
' Get local setting for thousand's separator
' and eliminate them. Remove the next two lines
' if you don't want your users being able to
' type in the thousands separator at all.
TS = Mid$(Format$(1000, "#,###"), 2, 1)
Value = Replace$(Value, TS, "")
' Leave the next statement out if you don't
' want to provide for plus/minus signs
If Value Like "[+-]*" Then Value = Mid$(Value, 2)
IsNumber = Not Value Like "*[!0-9" & DP & "]*" And _
Not Value Like "*" & DP & "*" & DP & "*" And _
Len(Value) > 0 And Value <> DP And _
Value <> vbNullString
End Function

Rick

code_wrong wrote:
> "code_wrong" <tac@tac.co.uk> wrote in message
> news:4404ac4c$1_3@mk-nntp-2.news.uk.tiscali.com...
>
>>Visual Basic (not dot net)
>>what is the best way to check the User has entered an integer into an
>>InputBox?
>>
>>isNumeric() checks for a numeric value .. but does not notify of numbers
>>with decimal places
>>inputBox returns a string so I could check for decimal point??? this seems
>>like overkill
>>
>>The value returned can be asigned into an Integer type and then a Single
>>type ... the two can be compared .. but still this does not complain about
>>numbers with decimal places if the fractional part is zero
>>
>>what is the simple solution?
>
>
> Interesting discussion , thanks for the replies.
> I have decided to provide students with a pre-defined function of my own
> design
> please review and improve if you can
> the function:
>
> Function isInteger(strVal As String) As Boolean
>
> 'if not numeric or decimal point found
> If Not IsNumeric(strVal) Or InStr(strVal, ".") Then
> isInteger = False
> Else
> isInteger = True
> End If
>
> End Function
>
>
>

If you have tested it and it works -- it works.

Does it need to be complicated for some reason?

Duane

"Rick Rothstein [MVP - Visual Basic]" <rickNOSPAMnews@NOSPAMcomcast.net>
wrote in message news:jN-dnUImFI79q5rZnZ2dnUVZ_tOdnZ2d@comcast.com...
>> I have decided to provide students with a pre-defined function of my own
>> design
>> please review and improve if you can
>> the function:
>>
>> Function isInteger(strVal As String) As Boolean
>>
>> 'if not numeric or decimal point found
>> If Not IsNumeric(strVal) Or InStr(strVal, ".") Then
>> isInteger = False
>> Else
>> isInteger = True
>> End If
>>
>> End Function
>
> From a previous post of mine...
>
> I usually try and steer people away from using IsNumeric to "proof"
> supposedly numeric text. Consider this (also see note below):
>
> ReturnValue = IsNumeric("($1,23,,3.4,,,5,,E67$)")
>
> Most people would not expect THAT to return True. IsNumeric has some
> "flaws"
> in what it considers a proper number and what most programmers are looking
> for.
>
> I had a short tip published by Pinnacle Publishing in their Visual Basic
> Developer magazine that covered some of these flaws. Originally, the tip
> was
> free to view but is now viewable only by subscribers.. Basically, it said
> that IsNumeric returned True for things like -- currency symbols being
> located in front or in back of the number as shown in my example (also
> applies to plus, minus and blanks too); numbers surrounded by parentheses
> as
> shown in my example (some people use these to mark negative numbers);
> numbers containing any number of commas before a decimal point as shown in
> my example; numbers in scientific notation (a number followed by an upper
> or
> lower case "D" or "E", followed by a number equal to or less than 305 --
> the
> maximum power of 10 in VB); and Octal/Hexadecimal numbers (&H for
> Hexadecimal, &O or just & in front of the number for Octal).
>
> NOTE:
> ======
> In the above example and in the referenced tip, I refer to $ signs and
> commas and dots -- these were meant to refer to your currency, thousands
> separator and decimal point symbols as defined in your local settings --
> substitute your local regional symbols for these if appropriate.
>
> As for your question about checking numbers, here are two functions that I
> have posted in the past for similar questions..... one is for digits only
> and the other is for "regular" numbers:
>
> Function IsDigitsOnly(Value As String) As Boolean
> IsDigitsOnly = Len(Value) > 0 And _
> Not Value Like "*[!0-9]*"
> End Function
>
> Function IsNumber(ByVal Value As String) As Boolean
> ' Leave the next statement out if you don't
> ' want to provide for plus/minus signs
> If Value Like "[+-]*" Then Value = Mid$(Value, 2)
> IsNumber = Not Value Like "*[!0-9.]*" And _
> Not Value Like "*.*.*" And _
> Len(Value) > 0 And Value <> "." And _
> Value <> vbNullString
> End Function
>
> Here are revisions to the above functions that deal with the local
> settings
> for decimal points (and thousand's separators) that are different than
> used
> in the US (this code works in the US too, of course).
>
> Function IsNumber(ByVal Value As String) As Boolean
> Dim DP As String
> ' Get local setting for decimal point
> DP = Format$(0, ".")
> ' Leave the next statement out if you don't
> ' want to provide for plus/minus signs
> If Value Like "[+-]*" Then Value = Mid$(Value, 2)
> IsNumber = Not Value Like "*[!0-9" & DP & "]*" And _
> Not Value Like "*" & DP & "*" & DP & "*" And _
> Len(Value) > 0 And Value <> DP And _
> Value <> vbNullString
> End Function
>
> I'm not as concerned by the rejection of entries that include one or more
> thousand's separators, but we can handle this if we don't insist on the
> thousand's separator being located in the correct positions (in other
> words,
> we'll allow the user to include them for their own purposes... we'll just
> tolerate their presence).
>
> Function IsNumber(ByVal Value As String) As Boolean
> Dim DP As String
> Dim TS As String
> ' Get local setting for decimal point
> DP = Format$(0, ".")
> ' Get local setting for thousand's separator
> ' and eliminate them. Remove the next two lines
> ' if you don't want your users being able to
> ' type in the thousands separator at all.
> TS = Mid$(Format$(1000, "#,###"), 2, 1)
> Value = Replace$(Value, TS, "")
> ' Leave the next statement out if you don't
> ' want to provide for plus/minus signs
> If Value Like "[+-]*" Then Value = Mid$(Value, 2)
> IsNumber = Not Value Like "*[!0-9" & DP & "]*" And _
> Not Value Like "*" & DP & "*" & DP & "*" And _
> Len(Value) > 0 And Value <> DP And _
> Value <> vbNullString
> End Function
>

interesting, you have made a comprehensive study of the flawed isNumeric()
function
I don't understand this aspect of your code : Like "*[!0-9]*" can't find it
in my VB manual.
what's going on there?

cw