Tcl/Tk 8.5.4 RELEASED

Witek wrote:
>> It would have been nice if you posted the bug number instead of the above
>> URL.
>
> Here you are, 1936220
>
>> By attempting to use the ones from Microsoft over two or three releases.
>
> Why then tcl.tk website states that "applications that run unchanged across
> Windows, Mac OS X, Linux and more." ?

Because most do.


--
+--------------------------------+---------------------------------------+
| Gerald W. Lester |
|"The man who fights for his ideals is the man who is alive." - Cervantes|
+------------------------------------------------------------------------+

"Jeff Hobbs" <jeff.hobbs@gmail.com> wrote in message
news:8676982b-e2d7-4cc7-a437-d5c37212e676@a70g2000hsh.googlegroups.com...
On Aug 18, 4:47 pm, George Peter Staplin <georg...@xmission.com>
wrote:

I do encourage others to sign on as maintainers to lighten the load.
While it can seem overwhelming, it is also rewarding.

Jeff

How does one sign on as a maintainer ?

Sonya

Sonya In Disguise wrote:
> How does one sign on as a maintainer ?

See TIP 28. http://tip.tcl.tk/28

Not everything on that page is up to date, but the general information
should still be good enough to get you in the door.

--
| Don Porter Mathematical and Computational Sciences Division |
| donald.porter@nist.gov Information Technology Laboratory |
| http://math.nist.gov/~DPorter/ NIST |
|_________________________________________________ _____________________|

> Would you forward to me your suggested patches to fix this bug.

Comment and a workaroud provided by Ian Gay
on 2008-04-09 can be found in followups of bug tracker:

http://sourceforge.net/tracker/index...d=1936220&grou...

and consists simply in adding a '-takefocus 0' option, in tkfbox.tcl
line 1155, when creating the Ok/Open button.


--
Witek
http://trimen.pl/witek/

Jeff Hobbs wrote:
>
> Yes, to help, but not solve all the problems. Let's put this in
> perspective for my particular (over)load ... looking at my 'My
> SourceForge' page, I have 444 items assigned to me amongst multiple
> projects (mostly Tcl and Tk, includes bugs, patches and feature
> requests). In comparison, Tcl itself only has 365 open bugs. That
> also doesn't include items in the ActiveTcl tracker, and numerous
> other items I know need addressing.
>
> ActiveState does offer support to enterprises that require it for
> ActiveTcl and other dynamic languages. That doesn't mean I ignore
> requests from non-customers or that I sit on my hands waiting for
> people to sign on. Rather, I have healthy dose of daily items (oh,
> they day job) that fill my plate, and only after that can I get to the
> multitude of other items.
>
> I do encourage others to sign on as maintainers to lighten the load.
> While it can seem overwhelming, it is also rewarding.
>
> Jeff

It all boils down to popularity. The more users/companies who utilize
the software the more people/resources are available to act as maintainers.

Witek <mozga@trimen.pl.no.junk> wrote:
>> Would you forward to me your suggested patches to fix this bug.
> Comment and a workaroud provided by Ian Gay
> on 2008-04-09 can be found in followups of bug tracker:
> http://sourceforge.net/tracker/index...d=1936220&grou...
> and consists simply in adding a '-takefocus 0' option, in tkfbox.tcl
> line 1155, when creating the Ok/Open button.

Just from following the discussion, this doesn't look like a good
solution, afterall.

I'd find it a pity, if I couldn't <Tab> to the Ok/Open-button
(no matter how rarely I'd do it and instead just press enter).

Perhaps this is the reason, why it still isn't long done yet.

On Aug 20, 8:12*am, Andreas Leitgeb <a...@gamma.logic.tuwien.ac.at>
wrote:
> Witek <mo...@trimen.pl.no.junk> wrote:
> >> Would you forward to me your suggested patches to fix this bug.
> > *Comment and a workaroud provided by Ian Gay
> > *on 2008-04-09 can be found in followups of bug tracker:
> >http://sourceforge.net/tracker/index...d=1936220&grou...
> > and consists simply in adding a '-takefocus 0' option, in tkfbox.tcl
> > *line 1155, when creating the Ok/Open button.
>
> Just from following the discussion, this doesn't look like a good
> solution, afterall.
>
> I'd find it a pity, if I couldn't <Tab> to the Ok/Open-button
> (no matter how rarely I'd do it and instead just press enter).
>
> Perhaps this is the reason, why it still isn't long done yet.

I've created a patch that does not require removing the focus.

I'm waiting for feedback before committing it to the 8.6 CVS head.


Try this out and see if you like it.


Index: library/tkfbox.tcl
================================================== =================
RCS file: /cvsroot/tktoolkit/tk/library/tkfbox.tcl,v
retrieving revision 1.68
diff -r1.68 tkfbox.tcl
1615,1617c1615,1617
< set selIcos [::tk::IconList_CurSelection $data(icons)]
< set data(selectFile) ""
< if {[llength $selIcos] == 0 && $text ne ""} {
---
> #set selIcos [::tk::IconList_CurSelection $data(icons)]
> #set data(selectFile) ""
> #if {[llength $selIcos] == 0 && $text ne ""} {
1620,1624c1620,1627
< VerifyFileName $w $text
< } else {
< foreach item $selIcos {
< VerifyFileName $w [::tk::IconList_Get $data(icons) $item]
< }
---
> #VerifyFileName $w $text
> #} else {
> #foreach item $selIcos {
> #VerifyFileName $w [::tk::IconList_Get $data(icons) $item]
> #}
> #}
> foreach t $text {
> VerifyFileName $w $t


-Todd

> I'm waiting for feedback before committing it to the 8.6 CVS head.

The patch works well for me. I think it should be incorporated into next
release of 8.5 (not only 8.6 CVS)

--
Witek
http://trimen.pl/witek/

thelfter@gmail.com wrote:
> On Aug 20, 8:12 am, Andreas Leitgeb <a...@gamma.logic.tuwien.ac.at>
> wrote:
>> Witek <mo...@trimen.pl.no.junk> wrote:
>>>> Would you forward to me your suggested patches to fix this bug.
>>> Comment and a workaroud provided by Ian Gay
>>> on 2008-04-09 can be found in followups of bug tracker:
>>> http://sourceforge.net/tracker/index...d=1936220&grou...
>>> and consists simply in adding a '-takefocus 0' option, in tkfbox.tcl
>>> line 1155, when creating the Ok/Open button.
>> Just from following the discussion, this doesn't look like a good
>> solution, afterall.
>>
>> I'd find it a pity, if I couldn't <Tab> to the Ok/Open-button
>> (no matter how rarely I'd do it and instead just press enter).
>>
>> Perhaps this is the reason, why it still isn't long done yet.
>
> I've created a patch that does not require removing the focus.
>
> I'm waiting for feedback before committing it to the 8.6 CVS head.
>
>
> Try this out and see if you like it.
>

No, that doesn't work when selecting a single filename containing a space.
I recommend the following additional patch:

--- tkfbox.tcl#org 2008-08-21 15:03:39.000000000 +0200
+++ tkfbox.tcl 2008-08-25 11:48:52.052875837 +0200
@@ -1783,7 +1771,7 @@
if {[llength $text] == 0} {
return
}
- if { [llength $text] > 1 } {
+ if {$data(-multiple)} {
set newtext {}
foreach file $text {
set fullfile [JoinFile $data(selectPath) $file]

The code contains another small bug. Can you also apply the following patch when committing your code?
@@ -614,7 +614,7 @@
return
}
IconList_Selection $w clear 0 end
- IconList_Selection $w set anchor $i
+ IconList_Selection $w anchor $i
}

Koen

Hi Koen,

This is the revised patch:
Index: tkfbox.tcl
================================================== =================
RCS file: /cvsroot/tktoolkit/tk/library/tkfbox.tcl,v
retrieving revision 1.68
diff -r1.68 tkfbox.tcl
617c617
< IconList_Selection $w set anchor $i
---
> IconList_Selection $w anchor $i
1611,1624c1611,1612
< # For the multiple case we have to be careful to get the file
< # names as a true list, watching out for a single file with a
< # space in the name. Thus we query the IconList directly.
<
< set selIcos [::tk::IconList_CurSelection $data(icons)]
< set data(selectFile) ""
< if {[llength $selIcos] == 0 && $text ne ""} {
< # This assumes the user typed something in without
selecting
< # files - so assume they only type in a single filename.
< VerifyFileName $w $text
< } else {
< foreach item $selIcos {
< VerifyFileName $w [::tk::IconList_Get $data(icons)
$item]
< }
---
> foreach t $text {
> VerifyFileName $w $t
1786c1774
< if { [llength $text] > 1 } {
---
> if {$data(-multiple)} {


Thanks for the feedback.

A bit more testing before I commit this to the CVS tree.

-Todd